docs(firebase_auth): Removed duplicates; fixed typos; removed "unnecessary use of a null check" #16815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikita0x
changed the title
Nikita0x
changed the title
|
I am not sure why some tests failed to be honest. I would like a help from somebody, I just changed the text in the docs mostly |
russellwheatley
requested changes
Jan 6, 2025
| @@ -61,7 +61,7 @@ class FirebaseAuth extends FirebasePluginPlatform { | |||
| /// [idTokenChanges] or [userChanges] to subscribe to updates. | |||
| User? get currentUser { | |||
| if (_delegate.currentUser != null) { | |||
| return User._(this, _delegate.currentUser!); | |||
| return User._(this, _delegate.currentUser); | |||
There was a problem hiding this comment.
Remove this change. See analyser CI: https://github.com/firebase/flutterfire/actions/runs/12146687849/job/34223264511?pr=16815#step:5:126
There was a problem hiding this comment.
@russellwheatley done
russellwheatley
requested changes
May 13, 2025
Comment on lines
225
to
227
| /// - **operation-not-allowed**: | ||
| /// - Thrown if email/password accounts are not enabled. Enable | ||
| /// email/password accounts in the Firebase Console, under the Auth tab. |
There was a problem hiding this comment.
I think this should be reinstated.
...ase_auth_platform_interface/lib/src/platform_interface/platform_interface_firebase_auth.dart
Outdated
Show resolved
Hide resolved
|
sorry, idk what I was thinking, those are clearly not duplicates 😰😰 |
russellwheatley
approved these changes
May 13, 2025
Lyokone
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docs:
Fixing typos, removing duplicates
Code:
Removed the "unnecessary use of a null check". Actually, it wasn't me but a compiler forced me to do it!
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?